Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic documentation and example for external access integrations & secrets (Snowpark concept) #5262

Merged
merged 8 commits into from
Apr 12, 2024

Conversation

ernestoongaro
Copy link
Contributor

What are you changing in this pull request and why?

dbt-labs/dbt-snowflake#925
dbt-labs/dbt-snowflake#955

Checklist

Wait until PR is merged

@ernestoongaro ernestoongaro requested a review from a team as a code owner April 10, 2024 23:27
Copy link

vercel bot commented Apr 10, 2024

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/concepts/teams/roles-and-permissions

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Apr 10, 2024
@ernestoongaro ernestoongaro changed the title Adds basic documentation and example Adds basic documentation and example for external access integrations & secrets (Snowpark concept) Apr 10, 2024
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 3:47pm

@mirnawong1
Copy link
Contributor

going to cc @matthewshaver as it looks like this related to v1.8. have mad some suggestions and the linked snowflake prs are still open as of today (4/11)

@ernestoongaro
Copy link
Contributor Author

tysm @mirnawong1 for your edits!

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 lgtm and thank you so v much @ernestoongaro for the initiative ✨

@mirnawong1
Copy link
Contributor

fixing spacing bc the rendering is looking weird
Screenshot 2024-04-12 at 16 31 49

@mirnawong1 mirnawong1 merged commit 001e0d2 into current Apr 12, 2024
10 of 11 checks passed
@mirnawong1 mirnawong1 deleted the dbt-snowflake-python-external-integrations branch April 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants