Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Python minimum version to 3.8 #3369

Merged
merged 13 commits into from
May 16, 2023
Merged

Conversation

sdebruyn
Copy link
Contributor

@sdebruyn sdebruyn commented May 15, 2023

What are you changing in this pull request and why?

Docs change for PR dbt-labs/dbt-core#7623 / issue dbt-labs/dbt-core#7082

resolves #3368

Checklist

  • Add versioning components, as described in Versioning Docs
  • Add a note to the prerelease version Migration Guide
  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@sdebruyn sdebruyn requested review from a team and dataders as code owners May 15, 2023 04:58
@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for docs-getdbt-com ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dcb3b17
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6463735255ce150008ee63c7
😎 Deploy Preview https://deploy-preview-3369--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels May 15, 2023
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR @sdebruyn !

This review has a couple suggestions that I will commit in a moment.

website/docs/faqs/Core/install-pip-os-prereqs.md Outdated Show resolved Hide resolved
website/docs/faqs/Core/install-python-compatibility.md Outdated Show resolved Hide resolved
dbeatty10
dbeatty10 previously approved these changes May 15, 2023
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't made a drop-down menu item for the 1.6 version of the docs yet, but I confirmed in the preview that it didn't create problems to include this ahead of time so it is ready when the time comes.

https://deploy-preview-3369--docs-getdbt-com.netlify.app/faqs/core/install-python-compatibility?version=1.6

Could you be extra confirmation @mirnawong1 ?

@sdebruyn
Copy link
Contributor Author

Thanks for raising this PR @sdebruyn !

This review has a couple suggestions that I will commit in a moment.

Sorry, looks like I wasn't wearing my glasses while typing those 3.8s 😂

@mirnawong1
Copy link
Contributor

This is awesome, thank you for opening this up @sdebruyn and for looking it over @dbeatty10 ! I made some small tweaks because the linked text wasn't rendering correctly due to spacing (see screenshot) but it looks great now! confirm the drop down works fine and doesn't harm the user experience. approved on my end, wdyt @dbeatty10 ?

Screenshot 2023-05-16 at 12 16 43

@dbeatty10
Copy link
Contributor

Looks great to meet @mirnawong1 -- squashing and merging.

@dbeatty10 dbeatty10 merged commit 57cbdb1 into dbt-labs:current May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs to reflect Python 3.7 is no longer supported
3 participants