-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Python minimum version to 3.8 #3369
Conversation
✅ Deploy Preview for docs-getdbt-com ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this PR @sdebruyn !
This review has a couple suggestions that I will commit in a moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't made a drop-down menu item for the 1.6 version of the docs yet, but I confirmed in the preview that it didn't create problems to include this ahead of time so it is ready when the time comes.
Could you be extra confirmation @mirnawong1 ?
Sorry, looks like I wasn't wearing my glasses while typing those |
This is awesome, thank you for opening this up @sdebruyn and for looking it over @dbeatty10 ! I made some small tweaks because the linked text wasn't rendering correctly due to spacing (see screenshot) but it looks great now! confirm the drop down works fine and doesn't harm the user experience. approved on my end, wdyt @dbeatty10 ? |
Looks great to meet @mirnawong1 -- squashing and merging. |
What are you changing in this pull request and why?
Docs change for PR dbt-labs/dbt-core#7623 / issue dbt-labs/dbt-core#7082
resolves #3368
Checklist