Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-381: redshift query tagging #3046

Closed

Conversation

trouze
Copy link
Contributor

@trouze trouze commented Mar 22, 2023

What are you changing in this pull request and why?

Associated with dbt-redshift PR #379

This pull request adds new sections to the Redshift setup and resource configuration documentation, explaining query tags and how to configure them in the dbt project file and individual models. It also includes information about the session-level scope of query tags and potential issues with incorrect tags during materialization.

Main documentation changes:

  • website/docs/reference/warehouse-setups/redshift-setup.md: Added a new section explaining query tags and how to configure them in the dbt project file and individual models. [1] [2] [3]
  • website/docs/reference/resource-configs/redshift-configs.md: Added a new section explaining query tags and how to set them in the dbt project file and individual models. Included information about the session-level scope of query tags and potential issues with incorrect tags during materialization.
  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@trouze trouze requested review from a team and dataders as code owners March 22, 2023 00:25
@welcome
Copy link

welcome bot commented Mar 22, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for docs-getdbt-com ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d76a1c7
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6477acd87e0db60008c6d047
😎 Deploy Preview https://deploy-preview-3046--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address labels Mar 22, 2023
@runleonarun runleonarun added the blocked_by_dev Awaiting merge of PR with associated functionality label Mar 22, 2024
@matthewshaver
Copy link
Contributor

The originating PR was closed as stale. It looks like there may be implementation plans in the future, we can revisit this when that time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked_by_dev Awaiting merge of PR with associated functionality content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants