hash macro + update surrogate_key #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthandy
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
assuming you've tested this on all 4 adapters and everything is working on each one, I'm 👍 . code looks great. thanks for building the test.
in general i'd be more comfortable if @drewbanin reviewed prs to this repo than myself though. would be good to get his thoughts prior to merging.
|
looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a hash macro that performs
md5by default. In BigQuery, convert the hash results (bytes) to hex (string). Employ this macro insurrogate_key.