Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readded where clause to accepted_range test #467

Closed
wants to merge 4 commits into from
Closed

Readded where clause to accepted_range test #467

wants to merge 4 commits into from

Conversation

ThorHen
Copy link

@ThorHen ThorHen commented Dec 20, 2021

This is a:

  • [ x ] bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Readded the where clause parameter described in the README.md for the accepted_range test originally defined in #276 and later (seemingly accidentally) removed in #372.

Renamed parameter to where_clause to avoid unintentional syntax highlighting in IDEs.

Changed default parameter value from true to none to be T-SQL compliant.

Checklist

  • [ x ] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • [ x ] BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt_utils.type_* macros instead of explicit datatypes (e.g. dbt_utils.type_timestamp() instead of TIMESTAMP
  • [ x ] I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@ThorHen
Copy link
Author

ThorHen commented Dec 20, 2021

Nvm, found this lovely post

@ThorHen ThorHen closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant