Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version info around, clean up some bumpversion stuff #72

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

beckjake
Copy link
Contributor

This PR is a bunch of minor version management stuff. Most of this will be reflected in an equivalent dbt-presto PR... soon.

Moving the spark version to its own file lets us use bumpversion without too much pain and nonsense.

  • Moved the spark version to a __version__.py in the spark adapter folder.

    • It would be super nice for dbt to parse this and report plugin versions in dbt --version and/or dbt debug
    • We parse this with an ugly regex
  • New bumpversion config: .bumpversion-dbt.cfg

    • updates setup.py, which has the required dbt version
    • access with bumpversion --config-file .bumpversion-dbt.cfg ...
  • Existing bumpversion config:

    • updates dbt/adapters/spark/version.py, which has the spark plugin version
    • access with bumpversion ... like before
    • has a new optional field, pluginpatch for issuing plugin patches when the dbt version hasn't incremented

@beckjake beckjake requested a review from jtcohen6 March 27, 2020 19:55
@beckjake beckjake force-pushed the feature/cleanup-versioning branch from f1b4376 to 090a99a Compare March 27, 2020 20:17
@jtcohen6
Copy link
Contributor

Everything in this PR makes sense to me. It feels a little overkill for just Spark right now, but as far as developing a framework that also works for Presto—and someday community-supported adapters, too—it's definitely worthwhile.

There are some unit test failures that are a bit unexpected. I don't see how they're related to changes you're making here, and we didn't see them in #69.

@beckjake
Copy link
Contributor Author

Those unit tests were 0.16.0 issues - I had to copy+paste test/unit/utils.py from dbt-core, and I had to do similar for presto. It would be good to get that into somewhere common but for now we'll just live that copy+paste life.

Set the circleci config go to v2.1
@beckjake beckjake force-pushed the feature/cleanup-versioning branch from 4082086 to bb9b56b Compare March 30, 2020 19:11
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I would love if dbt --version had a way of checking dbt/adapters/*/__version__.py. One of our many TODOs when it's time to tear out the core adapters.

@beckjake
Copy link
Contributor Author

beckjake commented Apr 2, 2020

There's a PR in active development by an external contributor that should handle this. I have high hopes for it getting into 0.17.0: dbt-labs/dbt-core#2279

@beckjake beckjake merged commit 975ec66 into master Apr 2, 2020
@beckjake beckjake deleted the feature/cleanup-versioning branch April 2, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants