Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ddtrace dependency range #932

Merged
merged 64 commits into from
Mar 19, 2024
Merged

Test ddtrace dependency range #932

merged 64 commits into from
Mar 19, 2024

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Mar 18, 2024

resolves #935
docs dbt-labs/docs.getdbt.com/#

Problem

A change in ddtrace or a upper dependency around helpconfig seems to be causing failures in adapters. setting bounds to be in the 2.3.x range seems to get us passing.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Mar 18, 2024
@McKnight-42 McKnight-42 removed the Skip Changelog Skips GHA to check for changelog file label Mar 19, 2024
@McKnight-42 McKnight-42 marked this pull request as ready for review March 19, 2024 07:26
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are a result of the dynamic table regression. This PR addresses the ddtrace issue, which should not be backported. In order to create separate PRs for tracking and for backporting, this should be merged with failed integration tests. These tests have been manually reviewed and are expected to fail at this point in time.

@mikealfare mikealfare merged commit 819c412 into main Mar 19, 2024
24 of 25 checks passed
@mikealfare mikealfare deleted the mcknight/test-ddtrace branch March 19, 2024 17:26
@McKnight-42 McKnight-42 restored the mcknight/test-ddtrace branch March 19, 2024 21:34
Copy link
Contributor

The backport to 1.3.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3.latest 1.3.latest
# Navigate to the new working tree
cd .worktrees/backport-1.3.latest
# Create a new branch
git switch --create backport-932-to-1.3.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 819c412c20e4ea1b7b553ecddc4a6fb67921ffc6
# Push it to GitHub
git push --set-upstream origin backport-932-to-1.3.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3.latest

Then, create a pull request where the base branch is 1.3.latest and the compare/head branch is backport-932-to-1.3.latest.

Copy link
Contributor

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-932-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 819c412c20e4ea1b7b553ecddc4a6fb67921ffc6
# Push it to GitHub
git push --set-upstream origin backport-932-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-932-to-1.2.latest.

Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-932-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 819c412c20e4ea1b7b553ecddc4a6fb67921ffc6
# Push it to GitHub
git push --set-upstream origin backport-932-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-932-to-1.5.latest.

Copy link
Contributor

The backport to 1.4.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-932-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 819c412c20e4ea1b7b553ecddc4a6fb67921ffc6
# Push it to GitHub
git push --set-upstream origin backport-932-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest

Then, create a pull request where the base branch is 1.4.latest and the compare/head branch is backport-932-to-1.4.latest.

colin-rogers-dbt pushed a commit that referenced this pull request Mar 27, 2024
* hard pin ddtrace to 2.3.0
* changelog

(cherry picked from commit 819c412)
colin-rogers-dbt pushed a commit that referenced this pull request Mar 27, 2024
* hard pin ddtrace to 2.3.0
* changelog

(cherry picked from commit 819c412)
mikealfare pushed a commit that referenced this pull request Mar 30, 2024
* Test ddtrace dependency range (#932)

* hard pin ddtrace to 2.3.0
* changelog

(cherry picked from commit 819c412)

* soft pin pytest and use ddtrace 2.6.4

* use ddtrace 2.3.0

* use pytest 7

---------

Co-authored-by: Matthew McKnight <[email protected]>
mikealfare pushed a commit that referenced this pull request Mar 30, 2024
* Test ddtrace dependency range (#932)

* hard pin ddtrace to 2.3.0
* changelog

(cherry picked from commit 819c412)

* soft pin pytest and use ddtrace 2.6

---------

Co-authored-by: Matthew McKnight <[email protected]>
@mikealfare mikealfare deleted the mcknight/test-ddtrace branch July 17, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Test ddtrace dependency range
3 participants