-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test ddtrace dependency range #932
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing tests are a result of the dynamic table regression. This PR addresses the ddtrace
issue, which should not be backported. In order to create separate PRs for tracking and for backporting, this should be merged with failed integration tests. These tests have been manually reviewed and are expected to fail at this point in time.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3.latest 1.3.latest
# Navigate to the new working tree
cd .worktrees/backport-1.3.latest
# Create a new branch
git switch --create backport-932-to-1.3.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 819c412c20e4ea1b7b553ecddc4a6fb67921ffc6
# Push it to GitHub
git push --set-upstream origin backport-932-to-1.3.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-932-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 819c412c20e4ea1b7b553ecddc4a6fb67921ffc6
# Push it to GitHub
git push --set-upstream origin backport-932-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-932-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 819c412c20e4ea1b7b553ecddc4a6fb67921ffc6
# Push it to GitHub
git push --set-upstream origin backport-932-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-932-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 819c412c20e4ea1b7b553ecddc4a6fb67921ffc6
# Push it to GitHub
git push --set-upstream origin backport-932-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest Then, create a pull request where the |
* hard pin ddtrace to 2.3.0 * changelog (cherry picked from commit 819c412)
* hard pin ddtrace to 2.3.0 * changelog (cherry picked from commit 819c412)
* Test ddtrace dependency range (#932) * hard pin ddtrace to 2.3.0 * changelog (cherry picked from commit 819c412) * soft pin pytest and use ddtrace 2.6.4 * use ddtrace 2.3.0 * use pytest 7 --------- Co-authored-by: Matthew McKnight <[email protected]>
* Test ddtrace dependency range (#932) * hard pin ddtrace to 2.3.0 * changelog (cherry picked from commit 819c412) * soft pin pytest and use ddtrace 2.6 --------- Co-authored-by: Matthew McKnight <[email protected]>
resolves #935
docs dbt-labs/docs.getdbt.com/#
Problem
A change in ddtrace or a upper dependency around
helpconfig
seems to be causing failures in adapters. setting bounds to be in the 2.3.x range seems to get us passing.Solution
Checklist