Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test constraints on model with sql header #647

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jun 1, 2023

adds test coverage for dbt-labs/dbt-core#7714

associated core PR: dbt-labs/dbt-core#7734

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Jun 1, 2023
@MichelleArk MichelleArk marked this pull request as ready for review June 1, 2023 19:28
@MichelleArk MichelleArk requested a review from a team as a code owner June 1, 2023 19:28
@MichelleArk MichelleArk requested a review from nathaniel-may June 1, 2023 19:28
@mikealfare
Copy link
Contributor

@MichelleArk I updated the branch and a lot of the tests are failing. My guess is that the dbt-core branch has already been merged. I would make sure that dev-requirements.txt is updated to reflect that.

@mikealfare mikealfare self-requested a review June 21, 2023 17:47
@MichelleArk
Copy link
Contributor Author

@mikealfare - done!

@mikealfare mikealfare merged commit e1cde45 into main Jun 21, 2023
@mikealfare mikealfare deleted the 7714/model-contracts-sql-header branch June 21, 2023 21:16
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
* test constraints on model with sql header

* revert dev-requirements.txt changes

---------

Co-authored-by: Mike Alfare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants