Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove submit_python_job from context and additional PR feedback for #260 #269

Merged
merged 1 commit into from
Sep 20, 2022
+2 −3
Merged

remove submit_python_job from context and additional PR feedback for #260 #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...sed/Breaking Changes-20220913-171057.yaml → ...eased/Under the Hood-20220913-171057.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
kind: Breaking Changes
kind: Under the Hood
body: Support anonymous sproc as submission method
time: 2022-09-13T17:10:57.647598-07:00
custom:
Expand Down
3 changes: 1 addition & 2 deletions dbt/adapters/snowflake/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ def standardize_grants_dict(self, grants_table: agate.Table) -> dict:
def timestamp_add_sql(self, add_to: str, number: int = 1, interval: str = "hour") -> str:
return f"DATEADD({interval}, {number}, {add_to})"

@available.parse_none
def submit_python_job(self, parsed_model: dict, compiled_code: str):
schema = parsed_model["schema"]
database = parsed_model["database"]
Expand Down Expand Up @@ -226,7 +225,7 @@ def submit_python_job(self, parsed_model: dict, compiled_code: str):
response, _ = self.execute(python_stored_procedure, auto_begin=False, fetch=False)
if not use_anonymous_sproc:
self.execute(
f"drop procedure if exists {proc_name}(string)",
f"drop procedure if exists {proc_name}()",
auto_begin=False,
fetch=False,
)
Expand Down