Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [CT-1200]: Skip grants on share objects #266

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

aaron-ortega
Copy link
Contributor

@aaron-ortega aaron-ortega commented Sep 19, 2022

resolves #264

Description

Change grants logic to skip over shares and, for now, only handle roles.

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 19, 2022
@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Sep 19, 2022
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! The change looks good to me!

How you feel about adding a test case for this? If not we can also add a note in the following issue about more complete feature you are requesting about shared object and do it there.

@aaron-ortega
Copy link
Contributor Author

@ChenyuLInx if it's ok with you I would rather add tests for the complete feature

@ChenyuLInx ChenyuLInx merged commit 21b5212 into dbt-labs:main Sep 22, 2022
@ChenyuLInx
Copy link
Contributor

Sounds good!! @aaron-ortega thanks for contributing this!!!

@aaron-ortega aaron-ortega deleted the fix/skip-grants-on-shares branch September 22, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1200] [Bug] Grants colliding with Snowflake Shares
3 participants