-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microbatch] Optimizations: use view for temp relation + remove using
clause during delete statement
#1192
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
using
clause during insert
using
clause during insertusing
clause during delete statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
{% elif strategy == "delete+insert" and unique_key is none %} | ||
{% elif strategy in ["delete+insert", "microbatch"] and unique_key is none %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This is a greeeeaaaat catch! Nice!
resolves #1228
docs dbt-labs/docs.getdbt.com/# N/A
Problem
Microbatch performance is underwhelming for dbt-snowflake! A couple underlying reasons:
unique_key
necessaryusing
clause is unnecessary in the microbatchdelete
statement, because microbatch does not require a merge key and thewhere
clause is sufficient for a safe deletion.Solution
using
clauseChecklist