Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key pair secrets to ci workflows #1113

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add key pair secrets to ci workflows #1113

merged 1 commit into from
Jul 11, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We added new secrets, but they are not pulled into the CI workflows.

Solution

Update the workflows separately from the PRs that need those secrets.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 11, 2024
@mikealfare mikealfare requested a review from a team as a code owner July 11, 2024 15:57
@cla-bot cla-bot bot added the cla:yes label Jul 11, 2024
@mikealfare mikealfare linked an issue Jul 11, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jul 11, 2024
@mikealfare mikealfare merged commit e51c22d into main Jul 11, 2024
26 of 28 checks passed
@mikealfare mikealfare deleted the add-key-pair-to-ci branch July 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Improve key-pair auth performance
2 participants