Adap 953/merge agate lazy load #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ VersusFacit, sorry for radio silence, been really busy. Thanks for taking it on from where I left off. Much appreciated ❤️ |
| body: Lazy load agate | ||
| time: 2024-03-27T00:13:04.246062-04:00 | ||
| custom: | ||
| Author: dwreeves |
There was a problem hiding this comment.
@VersusFacit do you want to add your author?
There was a problem hiding this comment.
I'm on the merge commit :) but thank you
colin-rogers-dbt
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #953
closes #954
Problem
We want to lazy load agate and test it! @dwreeves got us started 🙌
Solution
I added a test to lazy load this that I can confirm with another unit test (for now) does lazy load agate into
sys.modules.Checklist