Initial use of adapter test framework #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VersusFacit
reviewed
Mar 14, 2022
dev_requirements.txt
Outdated
| @@ -1,6 +1,7 @@ | |||
| # install latest changes in dbt-core | |||
| # TODO: how to automate switching from develop to version branches? | |||
| git+https://github.com/dbt-labs/dbt.git#egg=dbt-core&subdirectory=core | |||
| git+https://github.com/dbt-labs/dbt-core.git@ct-236-adapter_tests#egg=dbt-core&subdirectory=core | |||
There was a problem hiding this comment.
Is this reference link temporary? Are we planning not to merge this until the corresponding fixtures are merged into Core?
There was a problem hiding this comment.
Since the code to support this is only in that branch, we need to refer to the branch to get CI tests to pass. After the dbt-core PR is merged, these will be changed to remove the branch.
gshank
force-pushed
the
ct-353-new_testing_framework_redshift
branch
from
71016dc to
df6c1a7
Compare
gshank
force-pushed
the
ct-353-new_testing_framework_redshift
branch
from
df6c1a7 to
54c8d60
Compare
ChenyuLInx
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #105
Description
Initial use of adapter tests in tests/adapter.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.