-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external_access_integration and secret to python model impl #955
Add external_access_integration and secret to python model impl #955
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @Lindblomsebastian |
6d30a27
to
4a10155
Compare
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @Lindblomsebastian |
CLA has now been signed. |
this is plural
Turns our secrets need to live in the schema in which they will be used and don't need to be run by ACCOUNTADMIN
httpx has no method called stats, it's status
I missed that the secrets you specify as values must also be specified in the external access integration. (See https://docs.snowflake.com/en/developer-guide/external-network-access/creating-using-external-network-access#using-the-external-access-integration-in-a-function-or-procedure) |
i've done this today but due to the security integration needing to know the schema of the secret I can't quite get it to work so asked ❄️ for help |
changed permissions of CI user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off to @colin-rogers-dbt for review now!
Since this PR introduces a new user interface (model-level config for cc: @dataders |
Thanks @dbeatty10 ! |
@dbeatty10 @colin-rogers-dbt - I have a PR for docs: dbt-labs/docs.getdbt.com#5262 |
… & secrets (Snowpark concept) (#5262) ## What are you changing in this pull request and why? dbt-labs/dbt-snowflake#925 dbt-labs/dbt-snowflake#955 ## Checklist Wait until PR is merged
This resolves #925
docs: dbt-labs/docs.getdbt.com#5262
Problem
EXTERNAL_ACCESS_INTEGRATION
andSECRETS
are not populated in the generated PROCSolution
Add
EXTERNAL_ACCESS_INTEGRATION
andSECRETS
to the generated PROC if they are part of the config.Checklist