Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Replace underscores with hyphens in account ids #1069

Closed
3 tasks done
colin-rogers-dbt opened this issue Jun 4, 2024 · 1 comment
Closed
3 tasks done

[Feature] Replace underscores with hyphens in account ids #1069

colin-rogers-dbt opened this issue Jun 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@colin-rogers-dbt
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

If an account uses underscores in their accound id it can cause issues with various url and auth libraries since it's not compliant with most specs. Per snowflake's docs we can replace underscores with hyphens so we should default to doing that.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@colin-rogers-dbt colin-rogers-dbt added enhancement New feature or request triage labels Jun 4, 2024
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 5, 2024

@jtcohen6 jtcohen6 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
@jtcohen6 jtcohen6 removed the triage label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants