Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Replace underscores with hyphens in account identifiers #1068

Closed
2 tasks done
jtcohen6 opened this issue Jun 4, 2024 · 0 comments · Fixed by #1067
Closed
2 tasks done

[Bug] Replace underscores with hyphens in account identifiers #1068

jtcohen6 opened this issue Jun 4, 2024 · 0 comments · Fixed by #1067
Labels
bug Something isn't working

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 4, 2024

Is this a new bug in dbt-snowflake?

  • I believe this is a new bug in dbt-snowflake
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Domain names containing underscores cause SSL issues (especially on Python 3.11+)

Expected Behavior

dbt-snowflake (via snowflake-connector-python) successfully connects to any Snowflake account, regardless of domain name + Python version, by replacing underscores with hyphens

Steps To Reproduce

  1. Have a Snowflake account containing an underscore
  2. Try connecting
  3. Change the account name to use a hyphen instead
  4. Succeeds

Relevant log output

No response

Environment

- Python: 3.11
- dbt-core: 1.8+
- dbt-snowflake: 1.8+

Additional Context

https://docs.snowflake.com/en/user-guide/admin-account-identifier#account-name

URLs that include underscores can sometimes cause issues for certain features, such as Okta SSO/SCIM. For this reason, Snowflake also supports a version of the account name that substitutes the hyphen character (-) in place of the underscore character.

A better resolution would be to make this fix within the Snowflake Python connector:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant