Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

fix deps running on the server with development version of dbt-core #45

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Mar 18, 2022

No description provided.

@cla-bot cla-bot bot added the cla:yes label Mar 18, 2022
@kwigley kwigley requested a review from drewbanin March 18, 2022 03:00
@drewbanin
Copy link
Contributor

@kwigley just wondering - is there a corresponding change in dbt-core that's required to make this work?

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwigley
Copy link
Contributor Author

kwigley commented Mar 18, 2022

No changes to core, I had not updated dbt-core locally to the latest commit when testing this locally originally. When I attempted to test this in devspace, I used the "HEAD" version of dbt in Cloud, this image was built by CI for the dbt-server repo which installed the latest commit of dbt-core. I didn't quite figure out exactly what changed in dbt-core that broke what I had tested locally. This is not confirmed, but I suspect 1 of or a combination of dbt-labs/dbt-core#4758 and dbt-labs/dbt-core#4610.

@kwigley kwigley merged commit fa5f2dc into main Mar 18, 2022
@kwigley kwigley deleted the add-debug-log branch March 18, 2022 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants