Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove BQ macro shim #508

Merged
merged 1 commit into from
Oct 25, 2024
Merged

remove BQ macro shim #508

merged 1 commit into from
Oct 25, 2024

Conversation

dave-connors-3
Copy link
Collaborator

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Closes #449

Description & motivation

Removing our BQ shim now that the fix landed in core.

this landed in dbt-bigquery 1.8.0 and above, so requires pinning the version in this package accordingly

Integration Test Screenshot

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@dave-connors-3 dave-connors-3 changed the title remove macro remove BQ macro shim Oct 25, 2024
b-per
b-per approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@b-per b-per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦞

@dave-connors-3 dave-connors-3 merged commit 95297ea into main Oct 25, 2024
11 checks passed
@dave-connors-3 dave-connors-3 deleted the dc/remove-bq-override branch October 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-per b-per b-per approved these changes

@graciegoheen graciegoheen Awaiting requested review from graciegoheen graciegoheen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove bigquery macro override
2 participants
@dave-connors-3 @b-per