Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uniqness test defined several times #389

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Support uniqness test defined several times #389

merged 1 commit into from
Oct 26, 2023

Conversation

kokorin
Copy link
Contributor

@kokorin kokorin commented Oct 25, 2023

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

No reported issue

Description & motivation

Our team has 2 dbt_utils.unique_combination_of_columns tests defined for the same model. Column set is different.
Latest release reports this case as a failure:

-- is_empty_fct_missing_primary_key_tests_ --
| RESOURCE_NAME             | RESOURCE_TYPE | MODEL_TYPE | IS_PRIMARY_KEY_TESTED | NUMBER_OF_TESTS_ON_MODEL |
| ------------------------- | ------------- | ---------- | --------------------- | ------------------------ |
| stg_xxx_yy__model_name_xx | model         | staging    |                 False |                        2 |

Integration Test Screenshot

TO BE DONE

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@kokorin
Copy link
Contributor Author

kokorin commented Oct 25, 2023

Trino tests failed because of trino.exceptions.Http502Error: error 502: bad gateway

Copy link
Collaborator

@b-per b-per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥖

@b-per b-per merged commit c36aa75 into dbt-labs:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants