Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Update CLI for group creation to use explicit option names for group owner properties #72

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Feature: Update CLI for group creation to use explicit option names for group owner properties #72

merged 4 commits into from
Jun 26, 2023

Conversation

nicholasyager
Copy link
Collaborator

@nicholasyager nicholasyager commented Jun 25, 2023 •
edited
Loading

This PR updates the CLI options for group owner creation. Whereas before we required the user to provide the name of the field being updated and the value, now we have explicit properties for --owner-name and --owner-email. Additional properties are also still accepted via the --owner-properties option, which parses a YAML string.

Old syntax:

dbt-meshify group \
  --owner name dave \
  --owner email [email protected] \
  --owner foo bar \
  test_group_2

New syntax:

dbt-meshify group \
  --owner-name dave \
  --owner-email [email protected] \
  --owner-properties '{foo: bar}' \
  test_group_2

Along the way, I also added an owner decorator that performs validation of --owner-* arguments to ensure that either a name or email is always provided (as per spec), and moved click decorator definitions to cli.py.

Resolves: #65

@nicholasyager
feat(cli): Changed CLI parameters for Ownership to be explicit
9c760c7 
I've updated how CLI arguments for owners work. Specifically, I've changed to arguments to no longer use user input to know the field name. Instad, there are new `--owner-name`, `--owner-email`, and `--owner-properties` fields. The `--owner-properties` field is used to supply a YML string that is parsed for extra properities in the object.

BREAKING CHANGE: Creates a breaking change in CLI arguments relative to current version
Resolves: dbt-labs#65
@nicholasyager
feat(cli): Add validation for new cli options. Move click definitions…
492d50a 
… to cli.py

Resolves: dbt-labs#65
@nicholasyager
test: Update tests to work with new argument structure
070f2ef
@nicholasyager nicholasyager added the enhancement New feature or request label Jun 25, 2023
@nicholasyager nicholasyager self-assigned this Jun 25, 2023
dave-connors-3
dave-connors-3 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@dave-connors-3 dave-connors-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦞

@nicholasyager nicholasyager merged commit 0a42cd3 into dbt-labs:main Jun 26, 2023
@nicholasyager nicholasyager deleted the nicholasyager-update_owner_entry_ui branch June 26, 2023 13:51
@nicholasyager nicholasyager mentioned this pull request Jun 26, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-connors-3 dave-connors-3 dave-connors-3 approved these changes

@graciegoheen graciegoheen Awaiting requested review from graciegoheen

Assignees

@nicholasyager nicholasyager

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--owner name dave seems odd
2 participants
@nicholasyager @dave-connors-3