Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default prerelease to true #179

Merged
merged 2 commits into from
Sep 25, 2023
Merged

default prerelease to true #179

merged 2 commits into from
Sep 25, 2023

Conversation

dave-connors-3
Copy link
Collaborator

Closes #169

This PR is a re-do of closed #171 so that I don't need to deal with merge conflicts on a Sunday!

This reverses the default behavior for the version commands, in particular, the default argument of prerelease to the ModelVersioner.bump_version() method, as controlled by the --latest flag -- default behavior is to add a new version, but not increment the latest_version unless the --latest flag is present

@dave-connors-3 dave-connors-3 changed the title updated latest flag, refactor integration tests default prerelease to true Sep 24, 2023
Copy link
Collaborator

@nicholasyager nicholasyager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is simply updated from the previous latest version PR, this is likely still good! ✅

@dave-connors-3 dave-connors-3 merged commit 056cd2b into main Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--pre-release should be the default behavior
2 participants