update linker logic using 1.6, bump dependency #117
Conversation
|
@nicholasyager -- i ran |
There was a problem hiding this comment.
@dave-connors-3 This PR seems both necessary and sufficient. Thanks for making these changes! ✅
| linker = Linker() | ||
| compiler.link_graph(linker=linker, manifest=manifest) | ||
| return Graph(linker.graph) | ||
| return linker.get_graph(manifest=manifest) |
There was a problem hiding this comment.
This is waaaaaay simpler. Kudos to whomever simplified this interface in Core.
| agate = ">=1.7.0,<1.8.0" | ||
| cffi = ">=1.9,<2.0.0" | ||
| click = ">=7.0,<9" | ||
| colorama = ">=0.3.9,<0.4.7" | ||
| click = "<9" | ||
| colorama = ">=0.3.9,<0.5" | ||
| dbt-extractor = ">=0.4.1,<0.5.0" | ||
| hologram = ">=0.0.14,<=0.0.16" | ||
| dbt-semantic-interfaces = ">=0.2.0,<0.3.0" | ||
| hologram = ">=0.0.16,<0.1.0" | ||
| idna = ">=2.5,<4" | ||
| isodate = ">=0.6,<0.7" | ||
| Jinja2 = "3.1.2" | ||
| Jinja2 = ">=3.1.2,<3.2.0" | ||
| logbook = ">=1.5,<1.6" | ||
| mashumaro = {version = "3.6", extras = ["msgpack"]} | ||
| minimal-snowplow-tracker = "0.0.2" | ||
| networkx = {version = ">=2.3,<3", markers = "python_version >= \"3.8\""} | ||
| mashumaro = {version = ">=3.8.1,<3.9.0", extras = ["msgpack"]} | ||
| minimal-snowplow-tracker = ">=0.0.2,<0.1.0" | ||
| networkx = ">=2.3,<4" |
There was a problem hiding this comment.
These are good additions. I'm glad that a number of these deps moved from being pinned to range locker.
| metrics: | ||
| - name: revenue | ||
| label: Revenue | ||
| model: ref('orders') | ||
| description: "Income from all orders less tax" | ||
|
|
||
| calculation_method: sum | ||
| expression: order_total - tax_paid | ||
|
|
||
| timestamp: ordered_at | ||
| time_grains: [day, week, month, quarter, year] |
There was a problem hiding this comment.
This is regrettable. Perhaps there's an opportunity to add back in metric tests / semantic model tests in 0.4.x 🤷🏻
this PR updates our package to use dbt-core 1.6, and updates the use of the
Linkerclass to incorporate the (simpler!) logic in 1.6 after a breaking change was introduced!closes #116