-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: implement the dbt-meshify connect
command
#104
Merged
Merged
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3f0b134
checkpoint: mostly working, tests failing
dave-connors-3 e0be64e
handle identifier class for ruamel
dave-connors-3 5fcbc50
mypy type updates - ignore DbtSubproject specific attributes in DbtSu…
dave-connors-3 c22ce02
update package logic to look for children of package model
dave-connors-3 83b4aa1
support package dependecies
dave-connors-3 bbc2b5b
logging
dave-connors-3 aa4dc53
passing tests exclamation point
dave-connors-3 68b897d
remove dest_proj_b -- it can't compile, and it's not used in any test…
dave-connors-3 1999c05
add feature for --packages-dir and --exclude-packages
dave-connors-3 3c8f914
rename file
dave-connors-3 9ab2bc1
Revert "remove dest_proj_b -- it can't compile, and it's not used in …
dave-connors-3 db236e8
edits from code review
dave-connors-3 3b055ec
remove old comment
dave-connors-3 335db9d
remove whitespace for help text
dave-connors-3 4e85784
pool set of dependecies before resolving
dave-connors-3 a5034e8
grammar ha ha
dave-connors-3 8b4c1a3
use fixture to clean up first two tests
dave-connors-3 5af261f
Update dbt_meshify/main.py
dave-connors-3 d29b431
Apply suggestions from code review
dave-connors-3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dave-connors-3: We previously discussed the appropriate place for this type of logic, and after some thinking I believe that this approach is the right one. Specifically, having the
Linker
class present aresolve_dependency
method that usesProjectDependency
s to identify file updates. In a ChangeSet world, this method will return a ChangeSet that describes what file operations need to be made for each Ref update, which is beautiful to work with. ✅