-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add selector for python models, creating default node color in DAG visualization #324
add selector for python models, creating default node color in DAG visualization #324
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Paul Schmidt.
|
2 similar comments
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Paul Schmidt.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Paul Schmidt.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulbenschmidt thanks for this contribution! I tested it out and everything looks great and works just as expected.
Is your email associated with your github handle? I checked our cla database and your handle is there as expected.
You'll also need to add a changelog entry. Seems like our docs are missing that piece of info! You can use the instructions here.
@jtcohen6 or @lostmygithubaccount can I get your input on the default node color, please?
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Paul Schmidt.
|
1 similar comment
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Paul Schmidt.
|
Thank you, @emmyoop! I revised the color so that it was darker and contrasted more with the white text. I also added a changlelog entry!
It is! I'm not sure why I can't get the error to disappear... |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Paul Schmidt.
|
@paulbenschmidt it looks like one of your commits was associated with a different email. You can either squash all your commits down to a single commit or you can create a new fork and move all your changes there with a new PR. That should resolve the CLA issue. |
3051089
to
2543984
Compare
@emmyoop - Thanks for the help! Squashing the commits did it! If you want me to start fresh in a new branch so that it's a bit cleaner, let me know! |
@paulbenschmidt that's great news! We squash all the commits down when we merge anyways so this is a fine solution. Once I get some feedback from @lostmygithubaccount or @jtcohen6 on the default color we will be good to merge! |
thanks for this contribution @paulbenschmidt! I think keeping in line with our blue-ish color scheme in the DAG, it'd be better to make this a more subtle blue variant by default. would you (or @emmyoop?) mind updating to another color? perhaps a "SlateBlue"? hex code #6A5ACD I haven't actually had a chance to see it myself. post-Coalesce, I think we'll consult with our design team on a default color scheme |
I've created #325 to track revisiting the color scheme as a whole. @paulbenschmidt, once you get the color updated to #6A5ACD this will be good to go! |
@emmyoop - Done! Example screenshot included below... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @paulbenschmidt for this contribution! Can't wait to see your next one 😃
resolves dbt-labs/dbt-core#5880
Description
Changes default color assignment of Python models in lineage graph so that they're easily distinguishable from SQL models. After scanning the current colors, I figured that some type of yellow would be the safest bet; I'm including a few variations below...
#e3ad06 (proposed) - it looks a little like mustard, but I wanted it to be dark enough for the characters to contrast
Checklist
changie new
to create a changelog entry