-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/render-meta-tags-for-sources #193
Conversation
…sources add meta information from sources to be picked up by rendering too
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @diegodewilde |
@drewbanin Signed CLA. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @diegodewilde, this looks good. In the future, we may want to think about whether meta properties defined on sources should be inherited by source tables; and if so, whether that inheritance should be additive or clobbering. In the meantime, this is definitely an improvement over status quo.
Could you add a changelog entry, and add yourself to the list of contributors?
Update CHANGELOG.md for next release.
You're welcome @jtcohen6, happy to be able to support! |
resolves #192
Description
This PR will adds the functionality to render
meta
tags from sources in the .yml file in dbt docs.