Restrict protobuf to 4.* versions #9630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protobuf v5 has breaking changes. Here we are limiting the protobuf dependency to one major version, 4, so that we don't have to patch over handling 2 different major versions of protobuf.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9630 +/- ##
==========================================
+ Coverage 88.00% 88.95% +0.95%
==========================================
Files 176 178 +2
Lines 22311 24319 +2008
==========================================
+ Hits 19634 21633 +1999
- Misses 2677 2686 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
There's already a pull request: #9614 |
Woops |
|
Reopening because #9614 only did the |
peterallenwebb
approved these changes
Feb 29, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-9630-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e4fe839e4574187b574473596a471092267a9f2e
# Push it to GitHub
git push --set-upstream origin backport-9630-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latestThen, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Protobuf v5 has breaking changes. Here we are limiting the protobuf dependency to one major version, 4, so that we don't have to patch over handling 2 different major versions of protobuf. (cherry picked from commit e4fe839)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Protobuf v5 has breaking changes. Here we are limiting the protobuf dependency to one major version, 4, so that we don't have to patch over handling 2 different major versions of protobuf. (cherry picked from commit e4fe839)
QMalcolm
added a commit
that referenced
this pull request
Feb 29, 2024
Protobuf v5 has breaking changes. Here we are limiting the protobuf dependency to one major version, 4, so that we don't have to patch over handling 2 different major versions of protobuf.
QMalcolm
added a commit
that referenced
this pull request
Feb 29, 2024
QMalcolm
added a commit
that referenced
this pull request
Feb 29, 2024
* Restrict protobuf to 4.* versions (#9630) Protobuf v5 has breaking changes. Here we are limiting the protobuf dependency to one major version, 4, so that we don't have to patch over handling 2 different major versions of protobuf. (cherry picked from commit e4fe839) --------- Co-authored-by: Quigley Malcolm <[email protected]> Co-authored-by: Quigley Malcolm <[email protected]>
QMalcolm
added a commit
that referenced
this pull request
Mar 11, 2024
* Restrict protobuf to 4.* versions (#9630) Protobuf v5 has breaking changes. Here we are limiting the protobuf dependency to one major version, 4, so that we don't have to patch over handling 2 different major versions of protobuf. (cherry picked from commit e4fe839) --------- Co-authored-by: Quigley Malcolm <[email protected]> Co-authored-by: Quigley Malcolm <[email protected]>
|
Is it possible to get a 1.7.10 hot-fix release out that JUST has this dependency change in it? As google released their new protobuf package an hour ago and now our automation is completely broken. |
|
1.7.10 is going out tomorrow |
This was referenced Mar 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9566
Problem
Protobuf v5 has breaking changes.
Solution
Restrict the protobuf dependency to one major version, 4, so that we don't have to patch over handling 2 different major versions of protobuf.
Checklist