Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8682: Override path-like args in dbt retry #8803

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

aranke
Copy link
Member

@aranke aranke commented Oct 10, 2023

resolves #8682

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 10, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (339957b) 86.43% compared to head (1ba3596) 86.46%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8803      +/-   ##
==========================================
+ Coverage   86.43%   86.46%   +0.02%     
==========================================
  Files         176      176              
  Lines       26024    26028       +4     
==========================================
+ Hits        22494    22504      +10     
+ Misses       3530     3524       -6     
Flag Coverage Δ
integration 83.26% <100.00%> (+0.02%) ⬆️
unit 64.84% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/task/retry.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke changed the title WIP: use new retry flags if available Override path-like args in dbt retry Oct 10, 2023
@aranke aranke changed the title Override path-like args in dbt retry Fix #8682: Override path-like args in dbt retry Oct 10, 2023
@aranke aranke requested review from emmyoop and ChenyuLInx October 10, 2023 17:27
@aranke aranke marked this pull request as ready for review October 10, 2023 17:30
@aranke aranke requested a review from a team as a code owner October 10, 2023 17:30
@aranke aranke merged commit 3f7f7de into main Oct 10, 2023
55 checks passed
@aranke aranke deleted the wip_retry_flags branch October 10, 2023 18:31
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3137] [Bug] dbt retry: Path-type flags passed to retry should override params from previous invocation
2 participants