Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump manifest jsonschema to v11, update v10 schema #8335

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 7, 2023

resolves #8333

Problem

We need to bump the manifest schema version for main to v11. This also updates and freezes the v10 schema.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested review from a team as code owners August 7, 2023 20:58
@gshank gshank requested review from wpowers-dbt and emmyoop and removed request for a team August 7, 2023 20:58
@cla-bot cla-bot bot added the cla:yes label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #8335 (b653c58) into main (556b404) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8335      +/-   ##
==========================================
+ Coverage   86.23%   86.25%   +0.02%     
==========================================
  Files         174      174              
  Lines       25518    25518              
==========================================
+ Hits        22005    22011       +6     
+ Misses       3513     3507       -6     
Files Changed Coverage Δ
core/dbt/contracts/graph/manifest.py 93.75% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Additionally, what would be the trade-offs if we published these schema versions with pretty-printing applied?

On the benefit side of things, it would make it easier to see diffs whenever making changes to a core/dbt/contracts/graph/v{schema_version}.json file. But I'm not sure if it would have negative impacts, like performance, etc.

@gshank
Copy link
Contributor Author

gshank commented Aug 8, 2023

I personally almost always prefer pretty-printed json. I'm not sure what we post in the schemas repo... Will have to look. It does make the files bigger and our manifest schema is on the large size. There wouldn't be much of a performance impact because we don't use these file schemas in our code.

@gshank gshank force-pushed the ct-2946-manifest_jsonschemas branch from 975d28b to b653c58 Compare August 9, 2023 01:36
@gshank gshank merged commit 41bb527 into main Aug 9, 2023
@gshank gshank deleted the ct-2946-manifest_jsonschemas branch August 9, 2023 02:55
@graciegoheen graciegoheen added the user docs [docs.getdbt.com] Needs better documentation label Oct 6, 2023
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2946] Bump manifest jsonschema to v11, update v10 schema
4 participants