-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump manifest jsonschema to v11, update v10 schema #8335
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8335 +/- ##
==========================================
+ Coverage 86.23% 86.25% +0.02%
==========================================
Files 174 174
Lines 25518 25518
==========================================
+ Hits 22005 22011 +6
+ Misses 3513 3507 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Additionally, what would be the trade-offs if we published these schema versions with pretty-printing applied?
On the benefit side of things, it would make it easier to see diffs whenever making changes to a core/dbt/contracts/graph/v{schema_version}.json
file. But I'm not sure if it would have negative impacts, like performance, etc.
I personally almost always prefer pretty-printed json. I'm not sure what we post in the schemas repo... Will have to look. It does make the files bigger and our manifest schema is on the large size. There wouldn't be much of a performance impact because we don't use these file schemas in our code. |
975d28b
to
b653c58
Compare
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4205 |
resolves #8333
Problem
We need to bump the manifest schema version for main to v11. This also updates and freezes the v10 schema.
Checklist