Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7179 #8279

Merged
merged 6 commits into from
Aug 2, 2023
Merged

Fix #7179 #8279

merged 6 commits into from
Aug 2, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Aug 2, 2023

resolves #7179

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #8279 (971b2c8) into main (5814928) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8279      +/-   ##
==========================================
- Coverage   86.26%   86.22%   -0.04%     
==========================================
  Files         174      174              
  Lines       25518    25518              
==========================================
- Hits        22012    22004       -8     
- Misses       3506     3514       +8     
Files Changed Coverage Δ
core/dbt/exceptions.py 69.36% <ø> (+0.21%) ⬆️

... and 4 files with indirect coverage changes

@aranke aranke marked this pull request as ready for review August 2, 2023 14:35
@aranke aranke requested a review from a team as a code owner August 2, 2023 14:35
@aranke aranke requested review from martynydbt and emmyoop and removed request for martynydbt August 2, 2023 14:35
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the changelog and add the label to skip the check in CI and this looks good to me.

.changes/unreleased/Under the Hood-20230802-153143.yaml Outdated Show resolved Hide resolved
@aranke aranke added the Skip Changelog Skips GHA to check for changelog file label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2310] [Bug] The test_no_introspect test fails intermittently
2 participants