Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed PR feedback #7642

Merged
merged 3 commits into from
May 16, 2023
Merged

Missed PR feedback #7642

merged 3 commits into from
May 16, 2023

Conversation

iknox-fa
Copy link
Contributor

resolves # No Ticket

This fixes some missed PR feedback in ##7628

@iknox-fa iknox-fa requested a review from aranke May 16, 2023 15:51
@iknox-fa iknox-fa requested a review from a team as a code owner May 16, 2023 15:51
@iknox-fa iknox-fa requested a review from gshank May 16, 2023 15:51
@cla-bot cla-bot bot added the cla:yes label May 16, 2023
@iknox-fa iknox-fa added the Skip Changelog Skips GHA to check for changelog file label May 16, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@iknox-fa iknox-fa removed the request for review from gshank May 16, 2023 15:52
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iknox-fa iknox-fa merged commit df23f68 into main May 16, 2023
@iknox-fa iknox-fa deleted the iknox/NO-TICKET-missed-pr-feedback branch May 16, 2023 18:50
@github-actions
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-7642-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df23f68dd4e26a5fa19e5cbed4b9f2cf33e62a7d
# Push it to GitHub
git push --set-upstream origin backport-7642-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-7642-to-1.5.latest.

@iknox-fa iknox-fa restored the iknox/NO-TICKET-missed-pr-feedback branch May 16, 2023 18:59
@github-actions
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-7642-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df23f68dd4e26a5fa19e5cbed4b9f2cf33e62a7d
# Push it to GitHub
git push --set-upstream origin backport-7642-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-7642-to-1.5.latest.

@github-actions
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-7642-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df23f68dd4e26a5fa19e5cbed4b9f2cf33e62a7d
# Push it to GitHub
git push --set-upstream origin backport-7642-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-7642-to-1.5.latest.

iknox-fa added a commit that referenced this pull request May 17, 2023
(cherry picked from commit df23f68)
@iknox-fa iknox-fa changed the title Missed PR fedback Missed PR feedback May 17, 2023
github-actions bot pushed a commit that referenced this pull request May 24, 2023
(cherry picked from commit df23f68)
leahwicz pushed a commit that referenced this pull request May 24, 2023
(cherry picked from commit df23f68)

Co-authored-by: Ian Knox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.5.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants