Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport dbt show enhancements into 1.5.latest #7578

Merged
merged 13 commits into from
May 11, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented May 9, 2023

resolves #

Description

Checklist

@aranke aranke requested a review from a team May 9, 2023 21:18
@aranke aranke requested a review from a team as a code owner May 9, 2023 21:18
@cla-bot cla-bot bot added the cla:yes label May 9, 2023
@aranke aranke requested a review from a team as a code owner May 9, 2023 21:50
@aranke aranke requested review from jtcohen6, stu-k and iknox-fa and removed request for a team and colin-rogers-dbt May 9, 2023 21:51
@aranke aranke changed the title Cherry pick dbt show enhancements into 1.5.latest Backport dbt show enhancements into 1.5.latest May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke added the Skip Changelog Skips GHA to check for changelog file label May 9, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented May 10, 2023

Let's not merge this until we've resolved the breaking change for dbt-bigquery and other adapters, described in #7545 (comment)

Update: Given that this is a breaking (?) change for the adapter execute method, I don't think we can backport this for inclusion in 1.5.latest. We can include the change in v1.6 with early callout in the docs migration guide. Is there any non-breaking way that we could look to get this working for v1.5?

@aranke
Copy link
Member Author

aranke commented May 11, 2023

@jtcohen6 Fixed, I think this should be good to merge now?

Already included in branch: print model version numbers
Included in PR: show with seed, inject SQL header into query
Excluded: limit in execute

@aranke aranke merged commit 2a3cab9 into 1.5.latest May 11, 2023
@aranke aranke deleted the backport-7544-to-1.5.latest branch May 11, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants