-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back compat for previous return type of collect_freshness
#7535
Back compat for previous return type of collect_freshness
#7535
Conversation
collect_freshness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-7535-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 35f8ceb7f1dc575f1fc2e9e573e526f64cf25c9f
# Push it to GitHub
git push --set-upstream origin backport-7535-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest Then, create a pull request where the |
* Back compat for previous retrurn type of 'collect_freshness' * Test fixups * PR feedback
…7548) * Back compat for previous retrurn type of 'collect_freshness' * Test fixups * PR feedback
resolves #7489
Background:
collect_freshness
macro (used bydbt source freshness
) returned just anagate.Table
of values.adapter_response
(metadata)Changes in this PR:
adapter.calculate_freshness
calculate_freshness
macro returns only anagate.Table
Checklist
collect_freshness
macro for 1.5 docs.getdbt.com#3331changie new
to create a changelog entry