Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT 2483 duplicate depends on nodes #7455

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Apr 24, 2023

resolves #7453

Description

In some circumstances we ended up with duplicates node unique_ids in depends_on.nodes. Use "add_node" method to check for existence of a unique_id before adding.

Checklist

@gshank gshank requested review from a team as code owners April 24, 2023 21:36
@gshank gshank requested review from emmyoop and Fleid April 24, 2023 21:36
@cla-bot cla-bot bot added the cla:yes label Apr 24, 2023
@gshank
Copy link
Contributor Author

gshank commented Apr 24, 2023

Also I threw in removing the various update_node calls (etc) which are now totally no-ops.

@gshank gshank requested a review from MichelleArk April 24, 2023 22:43
@gshank gshank requested review from a team and ChenyuLInx April 25, 2023 17:41
@gshank gshank merged commit d2f963e into main Apr 25, 2023
@gshank gshank deleted the ct-2483-duplicate_depends_on_nodes branch April 25, 2023 18:11
@aranke aranke mentioned this pull request May 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2483] Use depends_on.add_node instead of depends_on.nodes.append
2 participants