Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backwards compatibility and default argument for incremental_predicates #6628

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

dave-connors-3
Copy link
Contributor

resolves #6625

Description

Provides backwards compatibility for predicates arg name and defaults incremental_predicates=None

Checklist

@dave-connors-3 dave-connors-3 requested a review from a team as a code owner January 17, 2023 16:13
@cla-bot cla-bot bot added the cla:yes label Jan 17, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@dave-connors-3 dave-connors-3 requested a review from a team as a code owner January 17, 2023 16:14
@dave-connors-3 dave-connors-3 changed the title add backwards compatibility and default argument add backwards compatibility and default argument for incremental_predicates Jan 17, 2023
Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtcohen6 jtcohen6 merged commit f841a7c into main Jan 19, 2023
@jtcohen6 jtcohen6 deleted the ct-1829-revert-default-predicate-args branch January 19, 2023 14:20
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
…dicates` (#6628)

* add backwards compatibility and default argument

* changie <3

* Update .changes/unreleased/Fixes-20230117-101342.yaml

Co-authored-by: Jeremy Cohen <[email protected]>
(cherry picked from commit f841a7c)
leahwicz pushed a commit that referenced this pull request Jan 19, 2023
…dicates` (#6628) (#6660)

* add backwards compatibility and default argument

* changie <3

* Update .changes/unreleased/Fixes-20230117-101342.yaml

Co-authored-by: Jeremy Cohen <[email protected]>
(cherry picked from commit f841a7c)

Co-authored-by: dave-connors-3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1829] [Bug] [v1.4.0rc1] Back compat in get_merge_sql macro signature
3 participants