Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert 038_caching_tests #6612

Merged
merged 4 commits into from
Jan 18, 2023
Merged

convert 038_caching_tests #6612

merged 4 commits into from
Jan 18, 2023

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jan 13, 2023 •
edited
Loading

resolves #5951

Adapter PRs

Checklist

@jtcohen6 jtcohen6 added the Skip Changelog Skips GHA to check for changelog file label Jan 13, 2023
@jtcohen6 jtcohen6 requested review from a team as code owners January 13, 2023 21:27
@cla-bot cla-bot bot added the cla:yes label Jan 13, 2023
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Jan 13, 2023 •
edited
Loading

Wait to merge until::

  • this is running on dbt-snowflake too (only adapter repo we copied this test into)

jtcohen6
jtcohen6 commented Jan 13, 2023
View reviewed changes
test/integration/038_caching_tests/test_caching.py
self.assertEqual(relation.inner.schema, self.unique_schema())
self.assertEqual(relation.schema, self.unique_schema().lower())

self.run_dbt(['run'])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I followed this logic right: This second run was not actually re-returning the adapter, so relation and second_relation were being pulled from the same adapter.cache.relations, and we were just asserting equality between pointers to the same object in memory.

@jtcohen6 jtcohen6 mentioned this pull request Jan 13, 2023
Merged
5 tasks
aranke
aranke approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, few minor comments.
No need for re-review.

tests/adapter/dbt/tests/adapter/caching/test_caching.py Outdated Show resolved Hide resolved
tests/adapter/dbt/tests/adapter/caching/test_caching.py Show resolved Hide resolved
tests/adapter/dbt/tests/adapter/caching/test_caching.py Outdated Show resolved Hide resolved
@jtcohen6
Copy link
Contributor Author

@aranke Thanks for the review! I'll merge in as soon as all's green

@jtcohen6 jtcohen6 force-pushed the jerco/convert-caching-tests branch from a1ebcc1 to 0f65624 Compare January 18, 2023 21:11
@jtcohen6 jtcohen6 merged commit 066346f into main Jan 18, 2023
@jtcohen6 jtcohen6 deleted the jerco/convert-caching-tests branch January 18, 2023 21:37
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranke aranke aranke approved these changes

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may nathaniel-may was automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1263] 038_caching_tests
2 participants
@jtcohen6 @aranke