Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog entry for 5989/6432 #6560

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

jtcohen6
Copy link
Contributor

This also happened in #6496. I haven't been doing any exhaustive checking, just some spot-checking here or there while working on docs for v1.4.

Now that we're only linking to the issue, rather than both the issue + the PR—if we get one link wrong, it's the only link we're showing in the changelog / release notes. It's not a huge deal, but it could be misleading for some community members.

Is there any automation that could help us here? Or just an additional manual check during review? E.g. #6432 was linked to #5989 in the PR description (+ therefore also GitHub "Development" flow).

@jtcohen6 jtcohen6 added the Skip Changelog Skips GHA to check for changelog file label Jan 10, 2023
@jtcohen6 jtcohen6 requested a review from aranke January 10, 2023 12:23
@jtcohen6 jtcohen6 requested a review from a team as a code owner January 10, 2023 12:23
@jtcohen6 jtcohen6 requested a review from McKnight-42 January 10, 2023 12:23
@cla-bot cla-bot bot added the cla:yes label Jan 10, 2023
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you caught this @jtcohen6 !

Approving now and will merge immediately thereafter.

@dbeatty10 dbeatty10 merged commit 89cc89d into main Jan 10, 2023
@dbeatty10 dbeatty10 deleted the jerco/patch-changelog-entry-5989 branch January 10, 2023 13:57
@aranke
Copy link
Member

aranke commented Jan 10, 2023

My bad on this one; if I could select issues from a list, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants