-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer internal macros when called explicitly #5907
Prefer internal macros when called explicitly #5907
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
07a015a
to
35a7661
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual change looks fine. However, this isn't the correct test file format. I have the appetite to fix up the file formatting and will push the changes up to your branch.
guilty!
thank you so so so much @emmyoop 🙏 |
Close and reopen to re-kick off snyk and make sure my changes didn't cause anything bad! |
resolves #5720
Description
{{ dbt.internal_macro() }}
, prefer the version actually defined in the internal (dbt
) namespace. All of these macros should be dispatched, and still overrideable by end users, using more explicit nomenclature + config patterns.{{ internal_macro() }}
(no namespace), it will follow global macro resolution order, and a root project reimplementation ofinternal_macro
will take precedenceI haven't been able to come up with a concrete example of a behavior (however gnarly or undocumented) that worked before this change, and would be broken after. Let's run some functional tests and find out what breaks!
If things seem to be working, I can pull the reproduction case from #5720 (comment) into a new functional test.
Checklist
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PRchangie new
to create a changelog entry