-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove source quoting setting in adapter tests #5839
Conversation
I just had the same build failure in the dbt-sqlserver GH Actions as this one, something we can do about it or just ignore and retry? |
It looks like there's some issue regarding pulling down As for the change, they look good to me! @gshank what was the reason those quoting setting were added in the beginning, do we expect this to break tests in other adapter repos? |
Setting the quoting was copied from the earlier integration tests. It's quite possible that it was originally there because we ran multiple adapter tests on the same test suite? I think we might want to check what this does to the tests in Redshift, BigQuery, and Snowflake before merging though. If it breaks those tests we'd have to quickly do PRs to fix. |
Created a test pr to test this change in dbt-bigquery repo |
The tests in test PR works as expected, so I think this is good to go. @sdebruyn Thanks for contributing it!! |
resolves #5836
Description
As discussed in #5836, the adapter tests should not override the quoting policies defined in the adapters. I removed all quoting policies from this the docs generate test.
Checklist
changie new
to create a changelog entry