Add invocation_args_dict to ProviderContext #5782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gshank the Structured Logging Schema check failed but the integration tests pass when I run them locally. I was looking into using --log-format-json in the test itself: And then running the assert on the parsed_logs list of dicts. What are your thoughts on this? |
jtcohen6
reviewed
Sep 7, 2022
There was a problem hiding this comment.
Nice work @jared-rimmer! Just a teensy comment about naming, and one about fixing the failing test. Could you also create a changelog entry?
jtcohen6
added
Team:Language
ready_for_review
jared-rimmer
changed the title
jared-rimmer
changed the title
jared-rimmer
commented
Sep 8, 2022
Comment on lines
+66
to
+104
| def test_builtin_invocation_args_dict_function(self, project): | ||
| _, log_output = run_dbt_and_capture( | ||
| [ | ||
| "--debug", | ||
| "--log-format=json", | ||
| "run-operation", | ||
| "validate_invocation", | ||
| "--args", | ||
| "{my_variable: test_variable}", | ||
| ] | ||
| ) | ||
|
|
||
| parsed_logs = [] | ||
| for line in log_output.split("\n"): | ||
| try: | ||
| log = json.loads(line) | ||
| except ValueError: | ||
| continue | ||
|
|
||
| parsed_logs.append(log) | ||
|
|
||
| # Value of msg is a string | ||
| result = next( | ||
| ( | ||
| item | ||
| for item in parsed_logs | ||
| if "invocation_result" in item["data"].get("msg", "msg") | ||
| ), | ||
| False, | ||
| ) | ||
|
|
||
| assert result | ||
|
|
||
| # Result is checked in two parts because profiles_dir is unique each test run | ||
| expected = "invocation_result: {'debug': True, 'log_format': 'json', 'write_json': True, 'use_colors': True, 'printer_width': 80, 'version_check': True, 'partial_parse': True, 'static_parser': True, 'profiles_dir': " | ||
| assert expected in str(result) | ||
|
|
||
| expected = "'send_anonymous_usage_stats': False, 'event_buffer_size': 100000, 'quiet': False, 'no_print': False, 'macro': 'validate_invocation', 'args': '{my_variable: test_variable}', 'which': 'run-operation', 'rpc_method': 'run-operation', 'indirect_selection': 'eager'}" | ||
| assert expected in str(result) |
There was a problem hiding this comment.
I opted to add --log-format=json to the dbt method and parse the json logs then implement the asserts on this within the test rather than having it in the macro jinja.
Based on similar logic I found in test_query_comments
jared-rimmer
deleted the
feat/add-invocation-args-dict-to-provider-context-class
branch
josephberni
pushed a commit
to Gousto/dbt-core
that referenced
this pull request
Sep 16, 2022
* Add invocation_args_to_dict to ProviderContext * Change invocation_args_to_dict contextproperty to invocation_args_dict * Fix invocation_args_dict builtin test * Add CHANGELOG entry * Fix formatting
6 tasks
This was referenced Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5524
Description
invocation_args_dictcontextproperty to the ProviderContext class.test_context.pyusing a MacroContexttest_builtin_functionsthat prints {{invocation_args_dict}} to the logs. Again using a MacroContextChecklist
changie newto create a changelog entry