Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change postgres name truncation logic to be overridable. #5656

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

VersusFacit
Copy link
Contributor

resolves #5586

Description

Redshift locally drawing from postgres verified to not run into collisions for models <119 chars. At that level, database limits lead to warehouse caused cache errors. I added an exception message for this case to help users in this case along. It'll be rare in the Redshift case (127 char limit) but not necessarily postgres (63 char limit).

To make sure this worked on the Redshift adapter, I triggered the error, fixed in, then increased local model name lengths to 127 which as expected retriggered the error.

Redshift followup PR.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@VersusFacit VersusFacit self-assigned this Aug 16, 2022
@VersusFacit VersusFacit requested a review from a team as a code owner August 16, 2022 06:03
@cla-bot cla-bot bot added the cla:yes label Aug 16, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@VersusFacit VersusFacit requested a review from a team as a code owner August 16, 2022 06:05
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VersusFacit VersusFacit merged commit 0d02446 into main Aug 18, 2022
@VersusFacit VersusFacit deleted the CT-964/truncate_large_suffixes branch August 18, 2022 07:52
@leahwicz leahwicz added the backport 1.2.latest This PR will be backported to the 1.2.latest branch label Aug 18, 2022
github-actions bot pushed a commit that referenced this pull request Aug 18, 2022
* Change postgres name truncation logic to be overridable. Add exception with debugging instructions.

* Add changelog.

Co-authored-by: Mila Page <[email protected]>
(cherry picked from commit 0d02446)
VersusFacit added a commit that referenced this pull request Sep 5, 2022
* Change postgres name truncation logic to be overridable. Add exception with debugging instructions.

* Add changelog.

Co-authored-by: Mila Page <[email protected]>
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
* Change postgres name truncation logic to be overridable. Add exception with debugging instructions.

* Add changelog.

Co-authored-by: Mila Page <[email protected]>
josephberni pushed a commit to Gousto/dbt-core that referenced this pull request Sep 16, 2022
* Change postgres name truncation logic to be overridable. Add exception with debugging instructions.

* Add changelog.

Co-authored-by: Mila Page <[email protected]>
lialzm pushed a commit to lialzm/dbt-core that referenced this pull request Mar 11, 2023
…) (dbt-labs#5681)

* Change postgres name truncation logic to be overridable. Add exception with debugging instructions.

* Add changelog.

Co-authored-by: Mila Page <[email protected]>
(cherry picked from commit 0d02446)

Co-authored-by: Mila Page <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.2.latest This PR will be backported to the 1.2.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-964] [Regression] Truncate relation names when appending a suffix is creating cache inconsistency
4 participants