Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature CT-665 Allow control over the outer CTE identifier generated in ephemeral materialization #5488

Closed
wants to merge 2 commits into from

Conversation

miro-ur
Copy link

@miro-ur miro-ur commented Jul 18, 2022

resolves CT-665 #5273

Description

Add support for ephemeral models using a dot in file naming convention.
Prioritize alias if specified when creating node identifier and sanitize the identifier to make sure no illegal characters are used when creating CTEs that would cause a runtime error.

Checklist

@miro-ur miro-ur requested review from a team as code owners July 18, 2022 19:38
@cla-bot
Copy link

cla-bot bot commented Jul 18, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @miro-ur

@jtcohen6 jtcohen6 added the Team:Adapters Issues designated for the adapter area of the code label Aug 4, 2022
@jtcohen6
Copy link
Contributor

jtcohen6 commented Sep 7, 2022

Hey @miro-ur, thanks for the contribution! Are you able to sign the CLA? If not, we won't be able to merge your PR unfortunately :(

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Mar 7, 2023
@github-actions
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Mar 15, 2023
@jeancochrane
Copy link
Contributor

jeancochrane commented Aug 16, 2023

@jtcohen6 @miro-ur My team would love to get this merged so we can migrate to dot notation for our ephemeral model files, if I open a new PR with the same changes and sign the CLA would you be down to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that have gone stale Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants