Move data type macros into dbt-core #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2022
1 task
dbeatty10
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
I took a look at this PR plus this one. Both look awesome! Ready to rock in my opinion. 👍
So now it seems like we'd do the following:
- Merge this PR (you)
- Merge that PR (me)
Opened dbt-labs/docs.getdbt.com#1644 to handle the relevant documentation updates and assigned to myself.
This was referenced Jun 30, 2022
jtcohen6
commented
Jun 30, 2022
Comment on lines
+11
to
+13
| -- This will return 'text' by default | ||
| -- On Postgres + Snowflake, that's equivalent to varchar (no size) | ||
| -- Redshift will treat that as varchar(256) |
There was a problem hiding this comment.
I'm leaving these comments in, unless anyone feels strongly that they should be removed before merging. (They can always be removed after merging.)
|
@dbeatty10 Thanks for the quick review! Next steps:
|
jtcohen6
added
the
Team:Adapters
gshank
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Move data type macros into dbt-core * Changelog entry * Code quality checks. Fix type_float
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* Move data type macros into dbt-core * Changelog entry * Code quality checks. Fix type_float
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type_*macros to use built-in adapter capabilities dbt-utils#598Description
type_{X}macros fromdbt-utilsintodbt-core. In almost all cases, these macros are just a sugarier interface forapi.Column.translate_type, which leverages built-in type capabilitiesAfter some back-and-forth on what the right interface ought to be, we've landed on keeping the existing one. Users can confidently access a "string" type for data type casting, by calling macro named
type_string, which returns the correct word for string (text,varchar, etc) on that databaseChecklist
changie newto create a changelog entry