Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --target-path CLI flag #5402

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Add --target-path CLI flag #5402

merged 1 commit into from
Jul 7, 2022

Conversation

isidentical
Copy link
Contributor

@isidentical isidentical commented Jun 22, 2022

Resolves #5399.

Description

This PR implements --target-path/--log-path CLI flags and DBT_TARGET_PATH/DBT_LOG_PATH environment variables to customize target-path/log-path project options respectively.

Checklist

@isidentical
Copy link
Contributor Author

Also CC: @jtcohen6

Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution

@leahwicz
Copy link
Contributor

leahwicz commented Jul 6, 2022

@isidentical it looks like our code quality check is failing here https://github.com/dbt-labs/dbt-core/runs/7203181747?check_suite_focus=true#step:5:44

Could you please take a look at fixing that before we merge?

@isidentical isidentical requested review from a team and stu-k July 7, 2022 10:58
@isidentical
Copy link
Contributor Author

@leahwicz thanks for reminding me, updated!!

@leahwicz leahwicz merged commit c521fa6 into dbt-labs:main Jul 7, 2022
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
bneijt added a commit to BigDataRepublic/dbt-core that referenced this pull request Jun 23, 2023
add noop and warn tests

improve tests

rename tests

add view dropping test

add unmanaged schema test

make tests more dry

Delete tmp.csv

Manage schemas is optional

Add --target-path as a CLI option. (dbt-labs#5402)

Include py.typed in MANIFEST.in (dbt-labs#5703)

This enables packages that install dbt-core from pypi to use mypy.

wip: move manage logic to separate command

Add manage command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-767] [Feature] Supporting on-the-fly configuration of target-path
3 participants