Early return from dbt init if no available adapters #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added
the
ready_for_review
ChenyuLInx
reviewed
Jun 14, 2022
There was a problem hiding this comment.
@ulisesojeda Thanks for contributing this!! The changes looks good to me. Do you think you can also adjust the tests so that they don't fail?
ChenyuLInx
added
awaiting_response
and removed
ready_for_review
Sure thing @ChenyuLInx . Could you explain me how to mock |
ChenyuLInx
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Looks great! @ulisesojeda thanks for contributing and fixing the tests! And congrats on the first PR in dbt-core!!
isidentical
pushed a commit
to isidentical/dbt-core
that referenced
this pull request
Jul 7, 2022
* Exit from dbt init if no available adapters * adding chnagie change * fixing init_tests
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* Exit from dbt init if no available adapters * adding chnagie change * fixing init_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5365
Description
Early return from dbt init if no available adapters
Checklist
changie newto create a changelog entry