Improve pluralizations for Documentation and SqlOperation NodeTypes #5356
Conversation
Previously these were `docss` and `sqlss` which leaves something to be desired.
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @pdebelak |
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @pdebelak |
|
After checking with my employer, I've now been able to sign the CLA. |
jtcohen6
added
the
ready_for_review
|
Closing/reopening to trigger CI |
core/dbt/node_types.py
Outdated
| if self is self.Documentation: | ||
| return "docs blocks" | ||
| if self is self.SqlOperation: | ||
| return "sql operations" | ||
| return f"{self}s" |
There was a problem hiding this comment.
| if self is self.Documentation: | |
| return "docs blocks" | |
| if self is self.SqlOperation: | |
| return "sql operations" | |
| return f"{self}s" | |
| return f"{self}s" |
Instead, let's just rename the node strings more appropriately:
lines 15 to SqlOperation = "sql operation"
and line 16 to Documentation = "docs block"
There was a problem hiding this comment.
Makes sense, updated.
…5356) * Improve pluralizations for Documentation and SqlOperation NodeTypes Previously these were `docss` and `sqlss` which leaves something to be desired. * Add changie changelog entry for pluralization change * Slighly simplify node type pluralization tests * Update node type names for sql and docs so they match pluralizations
…bt-labs#5356) * Improve pluralizations for Documentation and SqlOperation NodeTypes Previously these were `docss` and `sqlss` which leaves something to be desired. * Add changie changelog entry for pluralization change * Slighly simplify node type pluralization tests * Update node type names for sql and docs so they match pluralizations
resolves #5352
Description
Previously these were
docssandsqlsswhich leaves something to be desired.Checklist
changie newto create a changelog entry