Remove duplicate dbt script entry

[groodt]

Description

Resolves: #5314

There is a duplicate dbt script entry in setup.py

When installing the wheel, the console_script is overwriting the hand-written code in scripts/dbt. pip should not be overwriting files during installation and will begin to log warnings at some point in future. See: pypa/pip#4625 (comment)

You can confirm this by installing dbt-core into a venv. The contents of the dbt script is an autogenerated console_script defined in entry_points and not the handwritten script.

/tmp
myvenv ❯ cat myvenv/bin/dbt
#!/private/tmp/myvenv/bin/python3.9
# -*- coding: utf-8 -*-
import re
import sys
from dbt.main import main
if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
    sys.exit(main())

---

This also results in errors when using pypa/installer which is stricter than pip.

/tmp
❯ python3 -m venv dbt_venv

/tmp
❯ source dbt_venv/bin/activate.fish

/tmp
dbt_venv ❯ python -m pip install installer
Collecting installer
  Using cached installer-0.5.1-py3-none-any.whl (452 kB)
Installing collected packages: installer
Successfully installed installer-0.5.1
WARNING: You are using pip version 22.0.4; however, version 22.1.1 is available.
You should consider upgrading via the '/private/tmp/dbt_venv/bin/python -m pip install --upgrade pip' command.

/tmp
dbt_venv ❯ python -m installer --destdir /tmp/example ~/Downloads/dbt_core-1.1.0-py3-none-any.whl
Traceback (most recent call last):
  File "/usr/local/Cellar/[email protected]/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/Cellar/[email protected]/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/private/tmp/dbt_venv/lib/python3.9/site-packages/installer/__main__.py", line 85, in <module>
    _main(sys.argv[1:], "python -m installer")
  File "/private/tmp/dbt_venv/lib/python3.9/site-packages/installer/__main__.py", line 81, in _main
    installer.install(source, destination, {})
  File "/private/tmp/dbt_venv/lib/python3.9/site-packages/installer/_core.py", line 109, in install
    record = destination.write_file(
  File "/private/tmp/dbt_venv/lib/python3.9/site-packages/installer/destinations.py", line 203, in write_file
    return self.write_to_fs(
  File "/private/tmp/dbt_venv/lib/python3.9/site-packages/installer/destinations.py", line 167, in write_to_fs
    raise FileExistsError(message)
FileExistsError: File already exists: /tmp/example/private/tmp/dbt_venv/bin/dbt

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
• I have run changie new to create a changelog entry

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @groodt

[ChenyuLInx]

@groodt Thanks for the help getting this into dbt-core!!