Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro modified from previous state with pkg #5224

Merged
merged 2 commits into from
May 13, 2022

Conversation

stu-k
Copy link
Contributor

@stu-k stu-k commented May 9, 2022

resolves #5202

Description

When iterating through nodes to check if any of its macro dependencies have been modified, the state selector will first check all upstream macro dependencies before returning a judgement.

Checklist

When iterating through nodes to check if any of its macro dependencies
have been modified, the state selector will first check all upstream
macro dependencies before returning a judgement.
@stu-k stu-k requested a review from a team May 9, 2022 18:13
@stu-k stu-k requested a review from a team as a code owner May 9, 2022 18:13
@stu-k stu-k requested review from iknox-fa and emmyoop May 9, 2022 18:13
@cla-bot cla-bot bot added the cla:yes label May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stu-k stu-k merged commit 7532420 into main May 13, 2022
@stu-k stu-k deleted the stu/ct-590-changed-macro-selection-pkg branch May 13, 2022 18:04
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request May 20, 2022
* Fix macro modified from previous state with pkg

When iterating through nodes to check if any of its macro dependencies
have been modified, the state selector will first check all upstream
macro dependencies before returning a judgement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants