Improve tracking error logging message #5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message logged when tracking posting fails now makes it more obvious that it is related to DBT's internal anonymous usage statistics, and explains how to disable it. As tracking failure doesn't real concern most users, we also reduce the logging level to "DEBUG" so it doesn't appear during normal use. Issue dbt-labs#5197 Signed-off-by: NicolasPA <[email protected]>
Signed-off-by: NicolasPA <[email protected]>
gshank
approved these changes
May 4, 2022
NicolasPA
deleted the
npa/feature/improve_tracking_error_loggin_message_CT-586
branch
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5197
Description
The error message logged when tracking posting fails now makes it more
obvious that it is related to DBT's internal anonymous usage
statistics, and explains how to disable it.
As tracking failure doesn't real concern most users, we also reduce the
logging level to "DEBUG" so it doesn't appear during normal use.
The use case that triggered this change proposal is using DBT without
an internet connection and wondering what this error meant.
Checklist
changie newto create a changelog entry