-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When parsing 'all_sources' should be a list of unique dirs #5176
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and simple way to dedup the list. I do want to point out that it will change the order of the final list since Set
s are unordered, so as long as that's not an issue this should be fine.
I would be ok backporting this since its a bug and it's a minimal change (most changes are involving test conversion) |
Yeah, it's only a couple of lines. I'll backport without the tests. |
* When parsing 'all_sources' should be a list of unique dirs * Changie * Fix some unit tests of all_source_paths * Convert 039_config_tests * Remove old 039_config_tests * Add test for duplicate directories in 'all_source_files' (cherry picked from commit f633e99)
…5256) * When parsing 'all_sources' should be a list of unique dirs * Changie * Fix some unit tests of all_source_paths * Convert 039_config_tests * Remove old 039_config_tests * Add test for duplicate directories in 'all_source_files' (cherry picked from commit f633e99) Co-authored-by: Gerda Shank <[email protected]>
…5176) * When parsing 'all_sources' should be a list of unique dirs * Changie * Fix some unit tests of all_source_paths * Convert 039_config_tests * Remove old 039_config_tests * Add test for duplicate directories in 'all_source_files'
resolves #5120
Description
When two (or more) of the "-paths" settings point to the same directory, the "all_sources" method will return duplicate directory names, causing the attempt to parse the same files twice.
Checklist
changie new
to create a changelog entry